Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix]: 'forbidden_chars' - the condition added for uploading via Drop or UploadPicker. #43495 #43512

Closed
wants to merge 8 commits into from
Closed

[Bugfix]: 'forbidden_chars' - the condition added for uploading via Drop or UploadPicker. #43495 #43512

wants to merge 8 commits into from

Conversation

arublov
Copy link
Member

@arublov arublov commented Feb 10, 2024

Summary

  1. Added the condition for uploading files via drop.
  2. Added the forbiddenCharacters parameter for UploadPicker (need to merge this pull request).

Checklist

[Bugfix]: 'forbidden_chars' - the condition added for uploading via D…
bd483b7 
…rop or UploadPicker. nextcloud#43495

Signed-off-by: Andrii Rublov <airublev@outlook.com>
@arublov arublov requested a review from skjnldsv as a code owner February 10, 2024 15:06
@arublov
Copy link
Member Author

arublov commented Feb 10, 2024 •
edited
Loading

@szaimen I apologize for the confusion I caused. I got a bit changed my environment, had to optimize it a bit, and as a result, it led to some spam. I'll try not to let this happen again in the future :)

Thanks for your help and comment.

@szaimen szaimen added the 3. to review Waiting for reviews label Feb 13, 2024
@szaimen szaimen added this to the Nextcloud 29 milestone Feb 13, 2024
@szaimen szaimen added the bug label Feb 13, 2024
@szaimen szaimen requested review from susnux, a team and nfebe and removed request for a team February 13, 2024 10:26
susnux
susnux requested changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about the codestyle (really not sure why ESLint does not complain?)

apps/files/src/services/DropService.ts Outdated Show resolved Hide resolved
apps/files/src/services/DropService.ts Outdated Show resolved Hide resolved
apps/files/src/services/DropService.ts Outdated Show resolved Hide resolved
apps/files/src/services/DropService.ts Outdated Show resolved Hide resolved
arublov and others added 4 commits February 13, 2024 18:46
@arublov @susnux
Update apps/files/src/services/DropService.ts
d02ce26 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Andrii Rublov <39839367+arublov@users.noreply.github.com>
@arublov @susnux
Update apps/files/src/services/DropService.ts
5e0ae97 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Andrii Rublov <39839367+arublov@users.noreply.github.com>
@arublov @susnux
Update apps/files/src/services/DropService.ts
f684766 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Andrii Rublov <39839367+arublov@users.noreply.github.com>
Code refactoring
1fc8e6e 
Signed-off-by: Andrii Rublov <airublev@outlook.com>
@arublov
Copy link
Member Author

arublov commented Feb 13, 2024

Some comments about the codestyle (really not sure why ESLint does not complain?)

@susnux I fixed my code according to your comments. Thank you.
Do I need to do something with ESLint? Maybe something on my side?

@arublov arublov requested a review from susnux February 13, 2024 17:57
susnux
susnux approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides that two nits it looks good to me

apps/files/src/services/DropService.ts Outdated Show resolved Hide resolved
apps/files/src/services/DropService.ts Outdated Show resolved Hide resolved
arublov and others added 2 commits February 13, 2024 22:09
@arublov
Update DropService.ts
935922c 
Signed-off-by: Andrii Rublov <39839367+arublov@users.noreply.github.com>
@arublov @susnux
Update apps/files/src/services/DropService.ts
bfcc036 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Andrii Rublov <39839367+arublov@users.noreply.github.com>
Refactor code - move forbiddenCharacters from computed to data
27d96c3 
Signed-off-by: Andrii Rublov <airublev@outlook.com>
@arublov arublov requested a review from skjnldsv February 16, 2024 19:46
@arublov arublov self-assigned this Feb 28, 2024
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 3, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@joshtrichards
Copy link
Member

Best as I can tell this was superseded by nextcloud-libraries/nextcloud-upload#1132 (fka: nextcloud-libraries/nextcloud-upload#1086) and 079d026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees

@arublov arublov

Labels
2. developing Work in progress bug
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

[Bug]: 'forbidden_chars' Not Enforced During File Uploads
5 participants
@arublov @joshtrichards @susnux @skjnldsv @szaimen